Products

Solutions

Learn More

Partners

Community

Blog

About

Welcome to the DNN Community Forums, your preferred source of online community support for all things related to DNN.
In order to participate you must be a registered DNNizen

HomeHomeDevelopment and...Development and...DNN Platform (o...DNN Platform (o...Why is JWTController internal?Why is JWTController internal?
Previous
 
Next
New Post
3/10/2018 9:44 PM
 
We have implemented an alternal login to our custom specific DNN solution using electronic certificates which works fine. Now we want to utilize that in an API based on the DNN Service Framework and using JWT tokens so that after a successful authentication with electronic ids, we will call the class and have that issue the necessary token.

However, to our surprise we noted that for some reason, the JwtController is marked as internal, meaning that this wont work (AFAIK), ie it can only be accessible using REST calls to the DNN Service Layer.

internal class JwtController : ServiceLocator, IJwtController

Whats the reason for this? Is there a thought to it or just a mistake? I can't see any obvious advantatges of it, and several disadvantages. The other authentication controllers in the Core seem to all be public.

We changed that to "public" locally and just built that DLL and replaced the normal Dnn.AuthServices.Jwt.dll and that seems to work fine, but for obvious reason, having customized version of the core is not good.

Is there a reason to this or should we just create a PullRequest for it to change?

https://github.com/dnnsoftware/Dnn.Platform/commits/development/DNN%20Platform/Dnn.AuthServices.Jwt/Components/Common/Controllers/JwtController.cs
 
New Post
3/11/2018 12:06 AM
 
Perhaps I should add that I know there are ways to access internal classes from other assemblies, but it is a bit cumbersome, especially in a WebAPI. So if there is no reason for it being internal...
 
Previous
 
Next
HomeHomeDevelopment and...Development and...DNN Platform (o...DNN Platform (o...Why is JWTController internal?Why is JWTController internal?


These Forums are dedicated to discussion of DNN Platform and Evoq Solutions.

For the benefit of the community and to protect the integrity of the ecosystem, please observe the following posting guidelines:

  1. No Advertising. This includes promotion of commercial and non-commercial products or services which are not directly related to DNN.
  2. No vendor trolling / poaching. If someone posts about a vendor issue, allow the vendor or other customers to respond. Any post that looks like trolling / poaching will be removed.
  3. Discussion or promotion of DNN Platform product releases under a different brand name are strictly prohibited.
  4. No Flaming or Trolling.
  5. No Profanity, Racism, or Prejudice.
  6. Site Moderators have the final word on approving / removing a thread or post or comment.
  7. English language posting only, please.

Content Layout

Subscribe to DNN Digest

Subscribe to DNN Digest

DNN Digest is our monthly email newsletter. It highlights news and content from around the DNN ecosystem, such as new modules and themes, messages from leadership, blog posts and notable tweets. Keep your finger on the pulse of the ecosystem by subscribing.  

What is Liquid Content?
Find Out
What is Liquid Content?
Find Out
What is Liquid Content?
Find Out